handle when same componentize-py.toml appears twice in PYTHON_PATH#52
Merged
handle when same componentize-py.toml appears twice in PYTHON_PATH#52
Conversation
In this case, we need to decide which directory "owns" the file, which affects how we derive package names relative to that directory. For example, if both `foo` and `foo/.venv/lib/python3.12/site-packages` are in `PYTHON_PATH`, and we find a componentize-py.toml file under the latter, then we'll also find it under the former. In that case, we consider the latter to be the "owner" of the file. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this case, we need to decide which directory "owns" the file, which affects how we derive package names relative to that directory. For example, if both
fooandfoo/.venv/lib/python3.12/site-packagesare inPYTHON_PATH, and wefind a componentize-py.toml file under the latter, then we'll also find it under the former. In that case, we consider the latter to be the "owner" of the file.